MMPC/Alternativa3D
3
0
Fork 0
mirror of https://github.com/MapMakersAndProgrammers/Alternativa3D.git synced 2025-10-26 09:59:10 -07:00
Code Issues Packages Projects Releases Wiki Activity

Fixes extreme slowness of Geometry.rayIntersection.

Browse Source 
You are all going to love this pull request!

It fixes an extreme inefficiency in 'Geometry.rayIntersection' caused by using the 'indices' property rather than the '_indices' member. This was making three copies of the entire index array for EVERY triangle.

Ray intersections with complex models is now actually usable.

Enjoy!

Chris.
This commit is contained in:
ChrisDenham
2013-12-11 16:05:55 +00:00
parent 36c41f6c8e
commit 5b16652f83
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/alternativa/engine3d/resources/Geometry.as
View File

@@ -832,13 +832,13 @@ package alternativa.engine3d.resources {
uvStride = uvStream.attributes.length*4; uvStride = uvStream.attributes.length*4;
} }
if (numTriangles*3 > indices.length) { if (numTriangles*3 > _indices.length) {
throw new ArgumentError("index is out of bounds"); throw new ArgumentError("index is out of bounds");
} }
for (var i:int = indexBegin, count:int = indexBegin + numTriangles*3; i < count; i += 3) { for (var i:int = indexBegin, count:int = indexBegin + numTriangles*3; i < count; i += 3) {
var indexA:uint = indices[i]; var indexA:uint = _indices[i];
var indexB:uint = indices[int(i + 1)]; var indexB:uint = _indices[int(i + 1)];
var indexC:uint = indices[int(i + 2)]; var indexC:uint = _indices[int(i + 2)];
positionBuffer.position = indexA*stride + positionOffset; positionBuffer.position = indexA*stride + positionOffset;
var ax:Number = positionBuffer.readFloat(); var ax:Number = positionBuffer.readFloat();
var ay:Number = positionBuffer.readFloat(); var ay:Number = positionBuffer.readFloat();